Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remote launch #79

Merged
merged 23 commits into from
Feb 10, 2025
Merged

Remote launch #79

merged 23 commits into from
Feb 10, 2025

Conversation

swelborn
Copy link
Member

No description provided.

@swelborn swelborn force-pushed the remote-launch branch 3 times, most recently from b1b0e82 to b2053f9 Compare February 1, 2025 21:53
@swelborn swelborn requested a review from cjh1 February 5, 2025 14:12
@swelborn swelborn marked this pull request as ready for review February 5, 2025 14:12
- uses nats.micro to create service listening on two endpoints (status/submit)
- script generation works (see test, for ex.). However we don't have everything tested remotely yet
- will fixup launch_agent.sh later
we don't want to build sfapi_client dependencies into interactem.core, so we put in a separate package
- adds settings for `CONDA_ENV` and `ENV_FILE_PATH`in script
- removes agent id - we want to be able create multiple agents, depending on how many nodes we request
- updates tests to use .env in tests/
- updates tests to match changes
- we keep status as a req/rep
Add endpoint to create the pipeline AND run it (so that we only have one launch button).
- only "launch" button
- validation was not working correctly before
- hopefully this will be the last time we have to change this script :)
Copy link
Collaborator

@cjh1 cjh1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@swelborn swelborn merged commit e48cade into main Feb 10, 2025
2 checks passed
@swelborn swelborn deleted the remote-launch branch February 10, 2025 22:40
@swelborn swelborn mentioned this pull request Feb 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants